Open
Conversation
There was a problem hiding this comment.
Pull request overview
Enhances DSpace publication results logging by extracting more detail from DSS error payloads so errors are less frequently “N/A” and more actionable.
Changes:
- Replace single-field DSS error logging with a formatted, multi-field error summary (ErrorInfo/DSpaceResponse/ExceptionMessage/ExceptionTraceback).
- Add traceback formatting to keep stack traces readable (first few non-blank lines).
- Extend the job test to assert that DSS error payload details appear in the returned
results[:errors].
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/jobs/dspace_publication_results_job.rb | Adds format_dss_error + format_traceback and uses them when ResultType == 'error' to improve logged/error-report detail. |
| test/jobs/dspace_publication_results_job_test.rb | Adds an assertion ensuring ErrorInfo details are surfaced in the collected errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Why these changes are being introduced: Our current logging doesn't capture much information. (It usually just says 'N/A'.) While DSpace errors are not useful, we should still probably try to capture what's there. Relevant ticket(s): N/A How this addresses that need: That adds some Copilot-suggested changes to enhance our logging in the DSpace publication results job. Side effects of this change: None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
Our current logging doesn't capture much
information. (It usually just says 'N/A'.) While
DSpace errors are not useful, we should still
probably try to capture what's there.
Relevant ticket(s):
N/A
How this addresses that need:
That adds some Copilot-suggested changes to
enhance our logging in the DSpace publication
results job.
Side effects of this change:
None.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO